-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tagging for generic object instances #2286
Merged
h-kataria
merged 7 commits into
ManageIQ:master
from
lgalis:tagging_for_generic_object_instances
Oct 16, 2017
Merged
Add tagging for generic object instances #2286
h-kataria
merged 7 commits into
ManageIQ:master
from
lgalis:tagging_for_generic_object_instances
Oct 16, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgalis
changed the title
Add tagging for generic object instances
[WIP]Add tagging for generic object instances
Oct 3, 2017
lgalis
force-pushed
the
tagging_for_generic_object_instances
branch
6 times, most recently
from
October 13, 2017 13:48
0c1ba44
to
c390344
Compare
lgalis
force-pushed
the
tagging_for_generic_object_instances
branch
3 times, most recently
from
October 15, 2017 21:21
ef9b887
to
3ef6101
Compare
lgalis
force-pushed
the
tagging_for_generic_object_instances
branch
from
October 16, 2017 03:48
3ef6101
to
04c06ef
Compare
Checked commits lgalis/manageiq-ui-classic@a5e4fdc~...04c06ef with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 app/controllers/generic_object_controller.rb
app/helpers/application_helper/toolbar/generic_object_center.rb
app/helpers/application_helper/toolbar/generic_objects_center.rb
|
lgalis
changed the title
[WIP]Add tagging for generic object instances
Add tagging for generic object instances
Oct 16, 2017
@miq-bot add_label enhancement, fine/no |
@h-kataria -please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow tagging of Generic Object instances from the details page, initially when they are shown under a GO Class (in automate) or Service.
Links
https://www.pivotaltracker.com/story/show/151174596
https://bugzilla.redhat.com/show_bug.cgi?id=1497692