Translating availabilities/status for Domains/Servers/Deploys

[xeviknal]

Status literals of Domain/Server/Deployment translated and titleized.

Deployment status:

Domain state:

Server state:

[martinpovolny]

@xeviknal : how do these strings get to the catalog? Are we sure all of them are in the catalog? Thx!

[mzazrivec]

@xeviknal Also, what's the point of calling to_s() on a string? Why is the result of _().to_s being
titleized?

[xeviknal]

@martinpovolny two of the statuses are merged to Master (Server and Deployment). Domain availability is pending to merge (ManageIQ/manageiq-providers-hawkular#67).

@mzazrivec _(nil) #=> nil then needs a protection to nil access. It could happen when domain is created for first time, since properties by default is an empty hash. Calling to to_s makes it return an empty string. Another option, would be to call .try(:titleize).

Thanks for comments guys!

[martinpovolny]

@xeviknal : please, take a look at http://manageiq.org/docs/guides/i18n

the problem is the strings you are passwing throught i18n will not be in the gettext catalog unless you mark those somewhere the string collecting task would reach them

[mzazrivec]

Also, you should not be doing any more transformations with the strings coming out of _(). These
should really just be presented the way they come out. I.e. things should be done in such a way
that no to_s() nor titleize() should be needed here.

[xeviknal]

@martinpovolny then it means that I have to explicitly set the msgid for each translation. I can't use dynamic values to translate.

if value == 'Disabled'
   _('Disabled')
elsif value == 'Enabled'
   _('Enabled')
else
  _('Unknowkn')
end

@mzazrivec I understand what you mean. We fully trust on what translators do, and we don't have to manipulate anything from there. 👍

[abonas]

@miq-bot add_label middleware

[martinpovolny]

I am not sure what is the best pattern to use here.

A case statement is probably quite ok or maybe something like:

SERVER_STATES = {
 'Disabled' => N_('Disabled'),
 'Enabled' => N_('Enabled'),
 'Unknown' => N_('Unknown')
}.freeze

def translated_server_status(status)
  key = SERVER_STATES.key?(status) ? status : 'Unknown'
  _(SERVER_STATES[key])
end

Or you might leave the unknown message untranslated, that might be the best option for the user.

def translated_server_status(status)
  SERVER_STATES.key?(status) ?  _(SERVER_STATES[status]) : status
end

I'd refer to @mzazrivec as our i18n expert ;-)

[xeviknal]

@martinpovolny okay, apart from the pattern followed, I got how the system works now. 🎉
One other thing is, is there a common helper where to put common logic? I think translated_server_status method could be shared.

[martinpovolny]

@xeviknal : the textual_summary files are actually helpers. If you need to share code bettween those files, there are mixing included in several:
grep include $(find . -name 'textual_summary*')

So you might reuse one or create a new one if needed.

[abonas]

@xeviknal where does this PR stand? any more changes needed or it can be merged?

[xeviknal]

@martinpovolny @mzazrivec could you please check it out?
Thanks for helping me get onboarded 🥇

[miq-bot]

Checked commit xeviknal@d40de8e with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
5 files checked, 0 offenses detected
Everything looks fine. 🍰