Make the dragdrop placeholder in the main dashboard visible #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
changed the title
|
@skateman Looks good. Just add this change:
|
skateman
force-pushed
the
dashboard-dragdrop-placeholder
branch
from
95a459e
to
f4c1207
Compare
skateman
changed the title
|
@miq-bot add_label bug |
|
@miq-bot add_label fine/no |
|
@himdel can you please take a look? |
|
This pull request is not mergeable. Please rebase and repush. |
skateman
force-pushed
the
dashboard-dragdrop-placeholder
branch
from
f4c1207
to
1a80f58
Compare
|
Checked commit skateman@1a80f58 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
LGTM, merging 👍 |
|
Adding |
simaishi
pushed a commit
that referenced
this pull request
Nov 15, 2017
Make the dragdrop placeholder in the main dashboard visible (cherry picked from commit 1decfd8) https://bugzilla.redhat.com/show_bug.cgi?id=1511524
|
Gaprindashvili backport details: |
|
@skateman The BZ has cfme-5.8.z flag, but this PR is marked as |
|
@miq-bot add_label fine/yes |
simaishi
pushed a commit
that referenced
this pull request
Apr 18, 2018
Make the dragdrop placeholder in the main dashboard visible (cherry picked from commit 1decfd8) https://bugzilla.redhat.com/show_bug.cgi?id=1568168
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sortablemodule injquery-uiis not sensitive enough when moving a dashboard widget to the bottom of the page. I was trying to add some temporary extra padding when moving a widget, but that was not working. But as we're moving towards angular we'll drop all thejquerycode and so the issue will disappear. Until then I'm adding this placeholder feature to help the drag & drop process to be more understandable for the user.@epwinchell can you please review the styling of the placeholder box? I'm pretty sure I did it wrong 😉
https://bugzilla.redhat.com/show_bug.cgi?id=1485637