-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map the 'Inactive' status to Error #2396
Conversation
cc @Ladas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, we want red color. Not sure what color is warning, that might also fit.
Checked commit bronaghs@b731e50 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
@h-kataria btw. do you know, are those missing icons just in the @bronaghs env? Or something is broken? :-) |
@h-kataria - Looks like its broken, I was using the latest master code... |
@Ladas works fine for me on Chrome/Firefox on latest upstream/master |
Its a problem with Safari |
@bronaghs we don't support safari. |
https://bugzilla.redhat.com/show_bug.cgi?id=1488135
When a router or cloud network has a status value of "inactive" the circle in the network topology view currently turns grey. This is because the "inactive" status is set to "unknown". This PR sets it to 'Error' so it runs red.