Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map the 'Inactive' status to Error #2396

Merged
merged 1 commit into from
Oct 13, 2017

Conversation

bronaghs
Copy link

https://bugzilla.redhat.com/show_bug.cgi?id=1488135

When a router or cloud network has a status value of "inactive" the circle in the network topology view currently turns grey. This is because the "inactive" status is set to "unknown". This PR sets it to 'Error' so it runs red.

  • Add an AWS provider
  • Navigate to Compute/Clouds/Providers
  • Open the AWS provider
  • Click on the Network Manager
  • Click on Topology
  • Locate a network router or cloud network that is inactive (For this, I hardcoded the status property of a router to 'inactive' in the database)
  • Ensure the circle is red, not grey.

@bronaghs
Copy link
Author

cc @Ladas
@miq-bot assign @h-kataria

Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we want red color. Not sure what color is warning, that might also fit.

@miq-bot
Copy link
Member

miq-bot commented Oct 13, 2017

Checked commit bronaghs@b731e50 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@h-kataria h-kataria added this to the Sprint 71 Ending Oct 16, 2017 milestone Oct 13, 2017
@h-kataria h-kataria merged commit b02c131 into ManageIQ:master Oct 13, 2017
@bronaghs
Copy link
Author

Screenshots:
screen shot 2017-10-13 at 12 39 34 pm
screen shot 2017-10-13 at 12 40 57 pm

@Ladas
Copy link
Contributor

Ladas commented Oct 16, 2017

@h-kataria btw. do you know, are those missing icons just in the @bronaghs env? Or something is broken? :-)

@h-kataria
Copy link
Contributor

@Ladas i have no idea. @bronaghs do you know, i can sure try to recreate it locally if you want me to investigate it further.

@bronaghs bronaghs deleted the make_inactive_status_red branch October 16, 2017 13:54
@bronaghs
Copy link
Author

@h-kataria - Looks like its broken, I was using the latest master code...
Can you take a look @h-kataria ?

@h-kataria
Copy link
Contributor

@Ladas works fine for me on Chrome/Firefox on latest upstream/master
screenshot from 2017-10-16 16-38-52

@bronaghs
Copy link
Author

Its a problem with Safari

@h-kataria
Copy link
Contributor

@bronaghs we don't support safari.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants