Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Delete and Edit options to Cloud Networks toolbar #2417

Merged

Conversation

mansam
Copy link
Contributor

@mansam mansam commented Oct 16, 2017

Now that ManageIQ/manageiq#12551 is merged as mentioned in the section that was commented out, it should be possible to restore this functionality. It appears to work correctly for me.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1490393

@miq-bot
Copy link
Member

miq-bot commented Oct 16, 2017

Checked commit mansam@c37830c with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 2 offenses detected

app/helpers/application_helper/toolbar/cloud_networks_center.rb

@mzazrivec mzazrivec self-assigned this Oct 17, 2017
@mzazrivec mzazrivec added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 17, 2017
@mzazrivec mzazrivec merged commit 87c83da into ManageIQ:master Oct 17, 2017
simaishi pushed a commit that referenced this pull request Nov 20, 2017
…d-edit

Restore Delete and Edit options to Cloud Networks toolbar
(cherry picked from commit 87c83da)

https://bugzilla.redhat.com/show_bug.cgi?id=1511125
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 4730da3620a7f6b9585998939b643cc4fadaa3bd
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Tue Oct 17 12:50:21 2017 +0200

    Merge pull request #2417 from mansam/restore-cloud-networks-delete-and-edit
    
    Restore Delete and Edit options to Cloud Networks toolbar
    (cherry picked from commit 87c83da7be7b9e44462ee70a0a0c13b9cf80a79c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1511125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants