Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display the Custom Image in the nested Generic Object list #2421

Conversation

AparnaKarve
Copy link
Contributor

@AparnaKarve AparnaKarve commented Oct 16, 2017

Adjusted the indentation for the @record.picture conditional in the haml which fixed the issue of custom image being displayed in the nested GO list.

Before:
screen shot 2017-10-16 at 4 55 31 pm

After:
screen shot 2017-10-16 at 4 55 10 pm

This ensures that the Custom Image is not displayed in the nested
display list of the GOs
@miq-bot
Copy link
Member

miq-bot commented Oct 17, 2017

Checked commit AparnaKarve@ec5783c with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 1 offense detected

app/views/generic_object_definition/show.html.haml

  • ⚠️ - Line 14 - Prefer to_s over string interpolation.

@mzazrivec mzazrivec self-assigned this Oct 17, 2017
@mzazrivec mzazrivec added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 17, 2017
@mzazrivec mzazrivec merged commit 9c89fc3 into ManageIQ:master Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants