Notification type error should be rendered in patternfly as danger #2426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notification backend operates with the levels success, error, warning and info, however, PatternFly has success, danger, warning and info. We missed this inconsistency earlier so all the notifications with error levels appeared without the appropriate styling. I added a function in the frontend that converts the
error
to adanger
so PatternFly will understand it.Before:
After:
Testing:
https://bugzilla.redhat.com/show_bug.cgi?id=1489798
@miq-bot add_label bug, fine/yes