Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable MW Compliance and Control policies #2436

Merged
merged 1 commit into from
Oct 30, 2017

Conversation

karelhala
Copy link
Contributor

Introduces new menu item in Policies

Middleware provider needs to set up Compliance and Control policies. Base model is MW server, to create policy for EAP we have to cewate policy with scope somehow set to EAP.

screenshot from 2017-10-16 16-13-17 1
screenshot from 2017-10-11 15-20-53 1

@karelhala karelhala changed the title Enable MW Complience and Control policies Enable MW Compliance and Control policies Oct 18, 2017
@karelhala
Copy link
Contributor Author

@miq-bot add_label enhancement, middlaware

@miq-bot
Copy link
Member

miq-bot commented Oct 18, 2017

@karelhala Cannot apply the following label because they are not recognized: middlaware

@karelhala
Copy link
Contributor Author

@miq-bot add_label middleware

@abonas
Copy link
Member

abonas commented Oct 22, 2017

I'm comparing this PR with my old PR that attempts doing the same
(#1934)
I see that not the same files are changed here and in that PR. I wonder how is that possible :)
Is this PR also handling the dropdown like #1934? It will also need this PR iirc

@karelhala karelhala force-pushed the mwPolicies branch 3 times, most recently from ce523fc to 45d9c1a Compare October 26, 2017 10:46
@abonas
Copy link
Member

abonas commented Oct 26, 2017

@miq-bot add_label control

@abonas
Copy link
Member

abonas commented Oct 26, 2017

@jdoyleoss @Loicavenel I'd like to make sure - is this how you envision this feature in regards to EAP? that it's a sub category under middleware servers? (not saying it is incorrect, would like to verify with you that was the intention)

@karelhala
Copy link
Contributor Author

@abonas all should be done, this enables MW policies in control panel, but no button inside server to assign policies to specific entities. Because if I understand assigning of policies correctly if you were to add policy on Provider level, you will also assign such policy for all it's servers (which is OK) and all server's items (datasources, deployments and such) - might not be OK. But I might be mistaken @Loicavenel is this correct?

@abonas
Copy link
Member

abonas commented Oct 26, 2017

@abonas all should be done, this enables MW policies in control panel, but no button inside server to assign policies to specific entities. Because if I understand assigning of policies correctly if you were to add policy on Provider level, you will also assign such policy for all it's servers (which is OK) and all server's items (datasources, deployments and such) - might not be OK. But I might be mistaken @Loicavenel is this correct?

@karelhala I think you misunderstood my question, but the above also is an important thing to verify:

  • shouldn't we be able to assign an expression based on server's children?
    something like this? (and in this case PR #16312 misses some config)
  • per my original question - this UI lists MiddlewareServer as the top entity. At some point in the past @jdoyleoss wanted EAP to be top level entity. this is part of the reasons we had this change. perhaps I am completely misunderstanding something here... :)

@Loicavenel
Copy link

Based on the screenshots, this is what we discussed before and this will work.
What we discussed few times and I am not sure if you will implement it in the future is the Middleware Modeling:

1 - Everything is an EAP Server and this is a parameter that identify the Type: Fuse, DataVirt etc..
2 - There is one Object per Type: Fuse, DataVirt etc...

@abonas
Copy link
Member

abonas commented Oct 26, 2017

Based on the screenshots, this is what we discussed before and this will work.
What we discussed few times and I am not sure if you will implement it in the future is the Middleware Modeling:

1 - Everything is an EAP Server and this is a parameter that identify the Type: Fuse, DataVirt etc..

don't know what DataVirt is, but not everything is an EAP server.
and Fuse != EAP. @jdoyleoss please confirm

2 - There is one Object per Type: Fuse, DataVirt etc...

probably a more correct approach

@jdoyleoss
Copy link

jdoyleoss commented Oct 27, 2017 via email

@karelhala
Copy link
Contributor Author

@miq-bot assign @martinpovolny

@karelhala
Copy link
Contributor Author

@miq-bot assign @gtanzillo

@miq-bot miq-bot assigned gtanzillo and unassigned martinpovolny Oct 30, 2017
@miq-bot
Copy link
Member

miq-bot commented Oct 30, 2017

This pull request is not mergeable. Please rebase and repush.

@abonas
Copy link
Member

abonas commented Oct 30, 2017

@karelhala this needs a rebase and repush
@chessbyte who would be the most relevant person to review this PR about policies?

@abonas
Copy link
Member

abonas commented Oct 30, 2017

@aljesusg please review this as well

@karelhala
Copy link
Contributor Author

Failing travis is not problem of this PR.

@miq-bot
Copy link
Member

miq-bot commented Oct 30, 2017

Checked commit karelhala@9b41315 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
7 files checked, 0 offenses detected
Everything looks fine. 👍

@karelhala
Copy link
Contributor Author

@miq-bot assign @h-kataria
@h-kataria can you please look at this and ManageIQ/manageiq#16312. Thank you.

@miq-bot miq-bot assigned h-kataria and unassigned gtanzillo Oct 30, 2017
@karelhala
Copy link
Contributor Author

@martinpovolny or @h-kataria can you merge this? Travis error is not related.

@karelhala
Copy link
Contributor Author

@miq-bot assign @martinpovolny

@miq-bot miq-bot assigned martinpovolny and unassigned h-kataria Oct 30, 2017
@h-kataria
Copy link
Contributor

merging, Travis failures are unrelated to changes here.

@h-kataria h-kataria added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 30, 2017
@h-kataria h-kataria merged commit aeb89fa into ManageIQ:master Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants