Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom button with dialog #2439

Merged

Conversation

ZitaNemeckova
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova commented Oct 18, 2017

Create custom button with dialog:
Automation -> Automate -> Customization -> Buttons -> create a custom button with a dialog

COMPUTE

  • Cloud > Availability Zone
  • Cloud > Stacks
  • Infrastructure > Networking - explorer issue (submit/cancel in Dialog) - will be resolved in separate PR Fix custom button with dialog in explorer  #2593
  • Container > Project
  • Container > Pod
  • Container > Images
  • Container > Volumes
  • Container > Template

NETWORKS

  • Network
  • Subnet - not showing dialog - fixed
  • Router - not showing dialog -fixed
  • Load Balancer
  • Security Group - not showing dialog - fixed

STORAGE:

  • Block > Managers
  • Block > Volume
  • Object > Managers
  • Object > Container

Go to detail page of object that has custom button with a dialog

Before:

No route matches {:action=>"dialog_load", :controller=>"cloud_tenant", :id=>"1000000000012"} [cloud_tenant/button]

After:
Displays a dialog like this
screen shot 2017-10-18 at 1 49 05 pm

https://bugzilla.redhat.com/show_bug.cgi?id=1500199

@miq-bot add_label bug, fine/no

Dialog is generated directly instead of show's magic.
Template rendered instead of partial because of #main_div and styling.

Add missing routes, render correct template
dialog_provision is no longer rendered in show template
@ZitaNemeckova
Copy link
Contributor Author

@miq-bot add_label wip

@miq-bot miq-bot changed the title Fix custom button with dialog [WIP] Fix custom button with dialog Oct 18, 2017
@miq-bot miq-bot added the wip label Oct 18, 2017
@ZitaNemeckova
Copy link
Contributor Author

@miq-bot remove_label wip

@miq-bot miq-bot changed the title [WIP] Fix custom button with dialog Fix custom button with dialog Oct 24, 2017
@miq-bot miq-bot removed the wip label Oct 24, 2017
@miq-bot
Copy link
Member

miq-bot commented Oct 24, 2017

Checked commits ZitaNemeckova/manageiq-ui-classic@6245255~...461ae3e with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
7 files checked, 0 offenses detected
Everything looks fine. 👍

@mzazrivec mzazrivec self-assigned this Oct 25, 2017
@mzazrivec mzazrivec added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 25, 2017
@mzazrivec mzazrivec merged commit bc43673 into ManageIQ:master Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants