Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topology legend tooltip fix #2472

Merged
merged 1 commit into from
Oct 20, 2017
Merged

Topology legend tooltip fix #2472

merged 1 commit into from
Oct 20, 2017

Conversation

epwinchell
Copy link
Contributor

@epwinchell epwinchell commented Oct 19, 2017

This PR fixes a problem where the legend tooltip was not appearing. It also adjusts the positioning.

https://bugzilla.redhat.com/show_bug.cgi?id=1432851
https://bugzilla.redhat.com/show_bug.cgi?id=1486660

Old
screen shot 2017-10-19 at 3 39 30 pm

New
screen shot 2017-10-20 at 11 07 16 am

@epwinchell
Copy link
Contributor Author

@miq-bot add_label bug, topology, fine/no

@epwinchell
Copy link
Contributor Author

@miq-bot assign @h-kataria

@epwinchell
Copy link
Contributor Author

@miq-bot add_label wip

@epwinchell
Copy link
Contributor Author

@miq-bot unassign @h-kataria

@miq-bot miq-bot changed the title Topology legend tooltip fix [WIP] Topology legend tooltip fix Oct 19, 2017
@miq-bot miq-bot added the wip label Oct 19, 2017
@miq-bot
Copy link
Member

miq-bot commented Oct 19, 2017

@epwinchell unrecognized command 'unassign', ignoring...

Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@miq-bot
Copy link
Member

miq-bot commented Oct 20, 2017

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/bbf3a0f98ade102c2251932ab28a212a71dcf6d4 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 3 offenses detected

app/views/infra_topology/show.html.haml

  • ⚠️ - Line 1 - Use snake_case for variable names.

app/views/middleware_topology/show.html.haml

  • ⚠️ - Line 1 - Use snake_case for variable names.

app/views/physical_infra_topology/show.html.haml

  • ⚠️ - Line 1 - Use snake_case for variable names.

@epwinchell
Copy link
Contributor Author

@miq-bot rm_label wip

@miq-bot miq-bot changed the title [WIP] Topology legend tooltip fix Topology legend tooltip fix Oct 20, 2017
@miq-bot miq-bot removed the wip label Oct 20, 2017
@h-kataria
Copy link
Contributor

looks good

@h-kataria h-kataria added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 20, 2017
@h-kataria h-kataria merged commit 664a447 into ManageIQ:master Oct 20, 2017
@epwinchell epwinchell deleted the topology_tooltip_fix branch March 20, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants