Allow the type of controller to be passed in when adding a disk to a Vm ( VMWare ) #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgalis
changed the title
lgalis
force-pushed
the
add_disk_controller_to_vm_reconfigure
branch
from
8e11ada
to
c64297a
Compare
lgalis
changed the title
lgalis
changed the title
lgalis
changed the title
lgalis
changed the title
lgalis
force-pushed
the
add_disk_controller_to_vm_reconfigure
branch
from
993d367
to
4abb9eb
Compare
lgalis
force-pushed
the
add_disk_controller_to_vm_reconfigure
branch
2 times, most recently
from
e2b333f
to
acc3744
Compare
lgalis
force-pushed
the
add_disk_controller_to_vm_reconfigure
branch
from
acc3744
to
4ff43b2
Compare
|
Checked commits lgalis/manageiq-ui-classic@10a49a0~...4ff43b2 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
lgalis
changed the title
|
@lgalis Cannot apply the following label because they are not recognized: enahancement |
|
@miq_bot add_label pending_core |
|
@miq-bot add_label enhancement |
|
@h-kataria, @lfu - please review |
|
@miq-bot add_label pending core |
|
I got this when testing it. |
|
@lfu - you need the updates from this PR: ManageIQ/manageiq-providers-vmware#126 |
|
@lgalis 👍 Updated my environment and the testing looked good! A new SCSI controller with specified type was created when it ran out of port on the existing controller. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the user to enter a new disk controller type when adding a new disk to a VMWare VM via reconfigure
Links
https://www.pivotaltracker.com/story/show/152116440
Depends on ManageIQ/manageiq-providers-vmware#126
Before:
After - reconfigure VM and Edit Existing Reconfigure Request: