Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloud volume disk types to rate editor #2496

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Oct 24, 2017

Before change our chargeback rate editor for storage type looks like this:

screen shot 2017-10-24 at 10 45 33

After this change, when you have cloud volume types, the metric 'Allocated Storage Metric' is extended by items in cloud volumes types in
Storage -> Block Storage -> Cloud Volumes

So you can populate rates for this new dynamic cloud volume types.
The change is for newly added rates.

Test Scenario

cpsefwjltg

@miq-bot assign @mzazrivec
cc @gtanzillo

Links

@miq-bot miq-bot added the wip label Oct 24, 2017
@lpichler lpichler force-pushed the add_cloud_volume_disk_types_to_rate_editor_1 branch 2 times, most recently from 8678eea to babfe6e Compare October 25, 2017 14:11
@lpichler lpichler changed the title [WIP] Add cloud volume disk types to rate editor Add cloud volume disk types to rate editor Oct 25, 2017
@miq-bot miq-bot removed the wip label Oct 25, 2017
@mzazrivec
Copy link
Contributor

@lpichler Can you please address that %i-literals should be delimited by ( and ). rubocop warning?

@lpichler lpichler force-pushed the add_cloud_volume_disk_types_to_rate_editor_1 branch from babfe6e to 7ba0308 Compare October 26, 2017 12:04
@lpichler
Copy link
Contributor Author

@mzazrivec 👍

@miq-bot
Copy link
Member

miq-bot commented Oct 26, 2017

Checked commits lpichler/manageiq-ui-classic@03c3b7d~...7ba0308 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 1 offense detected

app/views/chargeback/_cb_rate_show.html.haml

  • ⚠️ - Line 30 - Line is too long. [215/160]

@mzazrivec mzazrivec added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 27, 2017
@mzazrivec mzazrivec merged commit c7652eb into ManageIQ:master Oct 27, 2017
@lpichler lpichler deleted the add_cloud_volume_disk_types_to_rate_editor_1 branch October 27, 2017 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants