Use decorators and fonticons on policy listing screens if possible #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some comments on commit skateman@9773f6e app/views/miq_policy/_policy_details.html.haml
|
|
Checked commit skateman@9773f6e with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Oh come on @miq-bot, that's just a variable and not a method call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a BZ where the physical infra image was missing with a 404 error. I found out that we're still using static images on some policy listing screens, so I'm replacing them with icons.
Before:
After:
Please ignore the error that there's some missing text in the last item, I'm going to fix it in a separate PR.
@miq-bot add_label bug
https://bugzilla.redhat.com/show_bug.cgi?id=1501139