Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed node id for policy after coming from an event #256

Merged
merged 1 commit into from
Jan 27, 2017

Conversation

nimrodshn
Copy link
Contributor

@nimrodshn nimrodshn commented Jan 26, 2017

Fixed the node_id in the evet_details.haml & _condition_list.haml - 'downcase' causes a number of bugs since the id given is NOT correct and should camelize lower instead.

Scenarios fixed:

  • When you click on an event link [In the Events accord in the Control page] and the select a policy and in that policy click on Events you will not be transferred back to the Events page.
  • When clicking on a condition in the conditions list [i.e. Container Image Condition etc..] and then clicking on one of the conditions it did not take you back to the relevant condition page.
    cc: @simon3z @cben

BZ:

@nimrodshn nimrodshn closed this Jan 26, 2017
@nimrodshn nimrodshn reopened this Jan 26, 2017
Added fix to bug on conditions accord
@miq-bot
Copy link
Member

miq-bot commented Jan 26, 2017

Checked commit nimrodshn@a5ecaee with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 👍

@nimrodshn
Copy link
Contributor Author

@miq-bot add_label bug, ui

@nimrodshn nimrodshn closed this Jan 27, 2017
@nimrodshn nimrodshn reopened this Jan 27, 2017
@mzazrivec mzazrivec self-assigned this Jan 27, 2017
@mzazrivec mzazrivec merged commit fc53af6 into ManageIQ:master Jan 27, 2017
@mzazrivec mzazrivec added this to the Sprint 53 Ending Jan 30, 2017 milestone Jan 27, 2017
@simaishi
Copy link
Contributor

simaishi commented Mar 2, 2017

Euwe backport (to manageiq repo) details:

$ git log -1
commit fe628f08489bf29d75ee23ce4af38f4bd36dcf2f
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Fri Jan 27 15:02:26 2017 +0100

    Merge pull request #256 from nimrodshn/event_page_broken_link_bug
    
    Fixed node id for policy after coming from an event
    (cherry picked from commit fc53af6a489b9471ac5255a2ad093c204f1b1f44)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1417762
    https://bugzilla.redhat.com/show_bug.cgi?id=1417779

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants