Refactor flash message text for consistency across all actions (Add/Edit/Delete/Cancel)

[GregP]

Refactor flash message ext construction to be consistent for all user actions. Previously code displayed Custom template name when adding or editing one and description when deleting. Code now calls same common to return consistent text, template description when available and name when description is not available.

https://bugzilla.redhat.com/show_bug.cgi?id=1486615

Screen shots prior to code fix, all showing hard coded template name:

Screen shots post code fix, showing common method returning template description for display:

[h-kataria]

@GregP this method is used to display name/description of selected record when performing certain tasks. Also this fix will defeat purpose of having following lines https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/application_controller.rb#L2257-L2259 because with your change it will always return name of record as name is usually a required field for most of CIs

[h-kataria]

@GregP i think the correct fix here is to make sure that methods call https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/application_controller.rb#L2255 method while performing any tasks so flash messages are consistent when add/editing or deleting objects.

[miq-bot]

Checked commit GregP@e222770 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

[GregP]

@h-kataria Ready for review.

[h-kataria]

looks good

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit d483865dc4f6479ee6da3033f942d006b4cf1d75
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Tue Nov 14 17:42:00 2017 -0500

    Merge pull request #2568 from GregP/confirm_delete_flash_msg_record_name
    
    Refactor flash message text for consistency across all actions (Add/Edit/Delete/Cancel)
    (cherry picked from commit 5aee298e3231525627fa3a2f51db07f58a15d874)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1513607

[simaishi]

Fine backport details:

$ git log -1
commit a23542630852ce472f040a4046cb7d6905232287
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Tue Nov 14 17:42:00 2017 -0500

    Merge pull request #2568 from GregP/confirm_delete_flash_msg_record_name
    
    Refactor flash message text for consistency across all actions (Add/Edit/Delete/Cancel)
    (cherry picked from commit 5aee298e3231525627fa3a2f51db07f58a15d874)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1515407