Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReportDataController spec - fix report_data mocking by removing too-specific contstraints #2582

Merged
merged 1 commit into from
Oct 31, 2017
Merged

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Oct 31, 2017

This should fix the spec failing with...

Error: Unexpected request: POST /mock_root/report_data
No more request expected

Courtesy of @karelhala, thanks! :)

…pecific constraints

should fix the spec failing with

```
Error: Unexpected request: POST /mock_root/report_data
No more request expected
```
@miq-bot
Copy link
Member

miq-bot commented Oct 31, 2017

Checked commit https://github.com/himdel/manageiq-ui-classic/commit/2e56520a004a6d3087c298664534de439ee7d3fa with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@chessbyte chessbyte self-assigned this Oct 31, 2017
@chessbyte chessbyte merged commit 7d95502 into ManageIQ:master Oct 31, 2017
@chessbyte chessbyte added this to the Sprint 73 Ending Nov 13, 2017 milestone Oct 31, 2017
simaishi pushed a commit that referenced this pull request Oct 31, 2017
ReportDataController spec - fix report_data mocking by removing too-specific contstraints
(cherry picked from commit 7d95502)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 436897db47f152783c051942fc8e2dd2759a839c
Author: Oleg Barenboim <chessbyte@gmail.com>
Date:   Tue Oct 31 13:50:28 2017 -0400

    Merge pull request #2582 from himdel/fix-report-data-post
    
    ReportDataController spec - fix report_data mocking by removing too-specific contstraints
    (cherry picked from commit 7d95502b58f9c967f45e4e26baf62f970e37384f)

@himdel himdel deleted the fix-report-data-post branch February 14, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants