Styling fix for Bootstrap switch on Tenant Quota screen #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug, formatting/styling, gaprindashvili/yes |
|
Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/fd29407a7fa9a8577965835d8a687f33eeabca98 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot assign @h-kataria |
|
@miq-bot add_label fine/yes |
simaishi
pushed a commit
that referenced
this pull request
Nov 6, 2017
Styling fix for Bootstrap switch on Tenant Quota screen (cherry picked from commit 1f8bfff) https://bugzilla.redhat.com/show_bug.cgi?id=1509422
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Nov 20, 2017
Styling fix for Bootstrap switch on Tenant Quota screen (cherry picked from commit 1f8bfff) https://bugzilla.redhat.com/show_bug.cgi?id=1509423
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug on the "Manage quotas for tenant" screen, where bootstrap switch was malformed because of a css setting that forced word breaks in TDs. This fix excludes the "table-view-pf-select" class (used for checkboxes, switches and icons) from using word-break and also cleans up extraneous markup on the screen. The problem is exposed when the UI is set to use the Japanese language.
https://bugzilla.redhat.com/show_bug.cgi?id=1495190
Before
After
