Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new tab for separate VMRC console credentials for vmware infra #2587

Merged
merged 1 commit into from
Nov 8, 2017

Conversation

skateman
Copy link
Member

@skateman skateman commented Nov 1, 2017

This is specific for the VMware infra provider only as it's the only one provider with VMRC support. The remote consoles should be able to run under a user other than the admin, therefore, @agrare created a new console authentication type on which PR depends.

screenshot from 2017-11-01 11-32-18

@miq-bot miq-bot added the wip label Nov 1, 2017
@skateman skateman force-pushed the vmware-console-tab branch 2 times, most recently from a41a7ad to db34741 Compare November 1, 2017 13:24
@skateman
Copy link
Member Author

skateman commented Nov 1, 2017

I'd like to make this new tab optional, but I can't untangle why is it required right now. Probably something with the validation, but I'm a bit lost. @AparnaKarve can you please help me?

@skateman skateman changed the title [WIP] Add a new tab for separate VMRC console credentials for vmware infra Add a new tab for separate VMRC console credentials for vmware infra Nov 1, 2017
@miq-bot miq-bot removed the wip label Nov 1, 2017
@AparnaKarve
Copy link
Contributor

@skateman Your last update looks good - I verified that the tab works correctly now.

@AparnaKarve
Copy link
Contributor

I think some of the CC errors can be fixed easily. (other than the Similar/Identical code)
Do take a look there. Thanks

@skateman
Copy link
Member Author

skateman commented Nov 3, 2017

@miq-bot assign @martinpovolny

@miq-bot
Copy link
Member

miq-bot commented Nov 7, 2017

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Nov 8, 2017

Checked commit skateman@10a5885 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 3 offenses detected

app/views/layouts/angular/_multi_auth_credentials.html.haml

  • ⚠️ - Line 24 - Redundant curly braces around a hash parameter.
  • ⚠️ - Line 301 - Prefer to_s over string interpolation.
  • ⚠️ - Line 302 - Prefer to_s over string interpolation.

@martinpovolny martinpovolny merged commit 30491e2 into ManageIQ:master Nov 8, 2017
@martinpovolny martinpovolny added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 8, 2017
@skateman skateman deleted the vmware-console-tab branch November 8, 2017 11:12
@skateman
Copy link
Member Author

skateman commented Nov 9, 2017

@miq-bot add_label fine/yes

simaishi pushed a commit that referenced this pull request Nov 15, 2017
Add a new tab for separate VMRC console credentials for vmware infra
(cherry picked from commit 30491e2)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 9d314855eb451ddd62be210e463fd96ddf01017d
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Wed Nov 8 12:10:50 2017 +0100

    Merge pull request #2587 from skateman/vmware-console-tab
    
    Add a new tab for separate VMRC console credentials for vmware infra
    (cherry picked from commit 30491e20d01c2441deadf05cf585d991da46827e)

@simaishi
Copy link
Contributor

@skateman There are lots of conflicts backporting this to Fine branch. Please create a separate PR.

@simaishi
Copy link
Contributor

Backported to Fine via #2780

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants