-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new tab for separate VMRC console credentials for vmware infra #2587
Conversation
a41a7ad
to
db34741
Compare
I'd like to make this new tab optional, but I can't untangle why is it required right now. Probably something with the validation, but I'm a bit lost. @AparnaKarve can you please help me? |
db34741
to
2bfccac
Compare
@skateman Your last update looks good - I verified that the tab works correctly now. |
I think some of the CC errors can be fixed easily. (other than the Similar/Identical code) |
2bfccac
to
5fd5f4d
Compare
@miq-bot assign @martinpovolny |
This pull request is not mergeable. Please rebase and repush. |
5fd5f4d
to
10a5885
Compare
Checked commit skateman@10a5885 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 app/views/layouts/angular/_multi_auth_credentials.html.haml |
@miq-bot add_label fine/yes |
Add a new tab for separate VMRC console credentials for vmware infra (cherry picked from commit 30491e2)
Gaprindashvili backport details:
|
@skateman There are lots of conflicts backporting this to Fine branch. Please create a separate PR. |
Backported to Fine via #2780 |
This is specific for the VMware infra provider only as it's the only one provider with VMRC support. The remote consoles should be able to run under a user other than the admin, therefore, @agrare created a new
console
authentication type on which PR depends.