Flavor delete vs tag

[martinpovolny]

Fix some issues from #1818

Most notably do not delete stuff when all you want is tagging.

Also add a specs for flavor#button

ping @h-kataria, @alexander-demichev, @tzumainn

[miq-bot]

Some comments on commits martinpovolny/manageiq-ui-classic@d2647e1~...9e7e095

spec/controllers/flavor_controller_spec.rb

• ⚠️ - 31 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

[miq-bot]

Checked commits martinpovolny/manageiq-ui-classic@d2647e1~...9e7e095 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

[aufi]

@martinpovolny Thanks for fixing it..

[martinpovolny]

@aufi: you are welcome ;-) please, review, test

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit c6bff38e57d9e7b494d01248790b586d531c10f8
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Fri Nov 3 13:15:19 2017 +0100

    Merge pull request #2590 from martinpovolny/flavor_delete_vs_tag
    
    Flavor delete vs tag
    (cherry picked from commit f2a53ddf70bd1810997a3551cfaf37e25814145a)