Adding methods for treeSelector into Dialog Editor's controller #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanblanco
force-pushed
the
tree_picker
branch
from
d4752e0
to
0269ce9
Compare
romanblanco
force-pushed
the
tree_picker
branch
from
0269ce9
to
7eaba50
Compare
|
@skateman @karelhala @martinpovolny please review |
romanblanco
changed the title
|
Checked commits romanblanco/manageiq-ui-classic@d66b9d8~...4b7626a with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 app/controllers/tree_controller.rb
|
|
Restarted travis. |
karelhala
approved these changes
Nov 6, 2017
|
@martinpovolny looks good, can you merge it please? Alongside with this we need to merge ManageIQ/ui-components#198 and release new version of |
|
This needs a new version of ui-component. Will wait to backport to gaprindashvili until new version becomes ready. Marking as conflict for now. cc @himdel |
|
@romanblanco I've just released manageiq-ui-components 1.0.1. Can you please follow the rest of the process? |
simaishi
pushed a commit
that referenced
this pull request
Nov 27, 2017
Adding methods for treeSelector into Dialog Editor's controller (cherry picked from commit 7b19340) https://bugzilla.redhat.com/show_bug.cgi?id=1510244
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to be merged together with ManageIQ/ui-components#198
Adding methods for
treeSelectorcomponent that is necessary for selecting automate methods in dialog editorLinks
Steps for Testing/QA
Automate -> Automation -> Customization -> Service Dialogs -> Add / Edit Dialog
