Change report data to be rendered using angular #26

karelhala · 2016-12-23T22:19:44Z

Purpose or Intent

TODO before merge:

Change back to pull from main repo in before_install.sh script
Update bower.json to use newest version of manageiq-ui-components
Fix Tagging in explorer.

To have much more responsible UI, we have to rewrite GTL to angular. So no longer generating views on rendering page, but with AJAX request.

To enable these components all at once we have to include specific route to each controller, this is done in routes.rb with default actions. Each controller will then have these default routes and will be able to list all entities. With this also new method in application_controller.rb is introduced, which will take care of filtering current view.

New angular module is introduced in this PR with one controller for fetching these data.

karelhala · 2016-12-23T22:22:04Z

Follow pull request of ManageIQ/manageiq#11114

@himdel @martinpovolny @dclarizio @epwinchell @serenamarie125 FYI

karelhala · 2016-12-23T22:23:25Z

@miq-bot add_label wip, ui, enhancment

miq-bot · 2016-12-23T22:23:33Z

@karelhala Cannot apply the following labels because they are not recognized: ui, enhancment

karelhala · 2017-01-04T09:12:57Z

@martinpovolny @dclarizio @himdel tests are green and it's same as in ManageIQ/manageiq#11114, two things needs to be done before merge update bower.json to fetch newest verion of ManageIQ/ui-components and I had to change 2 files in main ManageIQ/manageiq repo to make it work ManageIQ/manageiq#13344.

karelhala · 2017-01-06T14:55:16Z

@martinpovolny could you please look at this and ManageIQ/manageiq#13344

martinpovolny · 2017-01-10T07:33:00Z

app/controllers/application_controller.rb

+  end
+
+  # Private method for processing params.
+  # params can contain these oprions:


typo: "oprions"

martinpovolny · 2017-01-10T07:36:48Z

app/controllers/infra_networking_controller.rb

@@ -297,21 +298,18 @@ def get_node_info(treenodeid)
    end

    case model


options = case...

martinpovolny · 2017-01-10T07:38:21Z

app/controllers/provider_foreman_controller.rb

@@ -554,22 +556,22 @@ def get_node_info(treenodeid)

    case model


options = case ...

martinpovolny · 2017-01-10T07:42:19Z

app/helpers/quadicon_helper.rb

+               item.message
+             else
+               item.name
+             end


why this change?

There's been a test which failed with empty name, when MiqProvisionRequest used quadicon.

martinpovolny · 2017-01-10T07:44:13Z

app/views/layouts/angular/_gtl.html.haml

+  sendDataWithRx({initController: {
+    name: 'reportDataController',
+    data: {
+      modelName: '#{CGI::escape(j_str(@display.nil? && current_model ? controller.class.model.to_s.tableize : @display))}',


really want to html escape javascript escaped data? if so, use h instead of CGI::escape

martinpovolny · 2017-01-10T07:44:59Z

app/views/layouts/angular/_gtl.html.haml

+      sortColIdx: '#{@sortcol}',
+      sortDir: '#{@sortdir}',
+      isExplorer: '#{@explorer}' === 'true' ? true : false,
+      showUrl: '#{view_to_url(@view) if !@view.nil? && !@view.db.nil?}'


if @view.present? && @view.db.present?

martinpovolny · 2017-01-10T07:50:04Z

I get loads of CodeClimate warnings: missing ; and ,, stuff not declared as global etc. Can you, please, check the CC report? Some of the Rubocop issues also look relevant (and easy to fix).

…ort does not have downcase, do not return any image and show default image in report data

…l in report_data

Change icon to check if it can be created via glyphicon Show items in per page picker

@edit

…_ids in @edit

…panel

…ow ownership in nested screens

… class for icon based on view.db and row Use noSelectBox in bower

…rom string to integer, After clicking in configuration on GTL activete coresponding tree

@edit

Add correct policies in nested view Add explorer when adding policy for simulation if explorer is in @edit

miq-bot · 2017-03-06T16:53:34Z

Checked commits karelhala/manageiq-ui-classic@6d4b184~...296c6e4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
42 files checked, 59 offenses detected

app/controllers/application_controller.rb

❕ - Line 281, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for process_params_options is too high. [7/6]
❕ - Line 306, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for process_params_model_view is too high. [20.64/20]
❕ - Line 306, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for process_params_model_view is too high. [8/6]
❕ - Line 306, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for process_params_model_view is too high. [8/7]
❕ - Line 329, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for report_data is too high. [45.22/20]
❕ - Line 329, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for report_data is too high. [12/6]
❕ - Line 329, Col 3 - Metrics/MethodLength - Method has too many lines. [28/25]
❕ - Line 329, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for report_data is too high. [13/7]

app/controllers/automation_manager_controller.rb

❕ - Line 285, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for get_node_info is too high. [28.3/20]
❕ - Line 285, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for get_node_info is too high. [13/6]
❕ - Line 285, Col 3 - Metrics/MethodLength - Method has too many lines. [30/25]
❕ - Line 285, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for get_node_info is too high. [11/7]

app/controllers/catalog_controller.rb

❕ - Line 1662, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for get_node_info is too high. [150/20]
❕ - Line 1662, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for get_node_info is too high. [29/6]
❕ - Line 1662, Col 3 - Metrics/MethodLength - Method has too many lines. [110/25]
❕ - Line 1662, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for get_node_info is too high. [34/7]

app/controllers/chargeback_controller.rb

❕ - Line 384, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for get_node_info is too high. [81.5/20]
❕ - Line 384, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for get_node_info is too high. [18/6]
❕ - Line 384, Col 3 - Metrics/MethodLength - Method has too many lines. [66/25]
❕ - Line 384, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for get_node_info is too high. [21/7]

app/controllers/container_controller.rb

❕ - Line 150, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for get_node_info is too high. [26.12/20]
❕ - Line 150, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for get_node_info is too high. [8/7]

app/controllers/infra_networking_controller.rb

❕ - Line 295, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for get_node_info is too high. [26.13/20]
❕ - Line 295, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for get_node_info is too high. [12/6]
❕ - Line 295, Col 3 - Metrics/MethodLength - Method has too many lines. [31/25]
❕ - Line 295, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for get_node_info is too high. [10/7]

app/controllers/miq_ae_class_controller.rb

❕ - Line 139, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for get_node_info is too high. [49.67/20]
❕ - Line 139, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for get_node_info is too high. [10/6]
❕ - Line 139, Col 3 - Metrics/MethodLength - Method has too many lines. [37/25]
❕ - Line 139, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for get_node_info is too high. [9/7]

app/controllers/miq_policy_controller.rb

❕ - Line 398, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for get_node_info is too high. [46.49/20]
❕ - Line 398, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for get_node_info is too high. [13/6]
❕ - Line 398, Col 3 - Metrics/MethodLength - Method has too many lines. [28/25]
❕ - Line 398, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for get_node_info is too high. [8/7]

app/controllers/ops_controller.rb

❕ - Line 463, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for get_node_info is too high. [31.26/20]
❕ - Line 463, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for get_node_info is too high. [13/6]
❕ - Line 463, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for get_node_info is too high. [8/7]

app/controllers/provider_foreman_controller.rb

❕ - Line 302, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for get_node_info is too high. [32.02/20]
❕ - Line 302, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for get_node_info is too high. [13/6]
❕ - Line 302, Col 3 - Metrics/MethodLength - Method has too many lines. [33/25]
❕ - Line 302, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for get_node_info is too high. [13/7]

app/controllers/report_controller.rb

❕ - Line 496, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for get_node_info is too high. [27.04/20]
❕ - Line 496, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for get_node_info is too high. [12/6]
❕ - Line 496, Col 3 - Metrics/MethodLength - Method has too many lines. [29/25]
❕ - Line 496, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for get_node_info is too high. [10/7]

app/controllers/service_controller.rb

❕ - Line 193, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for get_node_info is too high. [31.56/20]
❕ - Line 193, Col 3 - Metrics/MethodLength - Method has too many lines. [26/25]

app/controllers/storage_controller.rb

❕ - Line 397, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for get_node_info is too high. [9/6]
❕ - Line 397, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for get_node_info is too high. [9/7]

app/controllers/vm_common.rb

❕ - Line 1045, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for get_node_info is too high. [124.2/20]
❕ - Line 1045, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for get_node_info is too high. [43/6]
❕ - Line 1045, Col 3 - Metrics/MethodLength - Method has too many lines. [117/25]
❕ - Line 1045, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for get_node_info is too high. [47/7]
❕ - Line 1130, Col 11 - Metrics/BlockNesting - Avoid more than 3 levels of block nesting.
❕ - Line 1142, Col 11 - Metrics/BlockNesting - Avoid more than 3 levels of block nesting.

app/helpers/application_helper.rb

❕ - Line 1600, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for listicon_glyphicon is too high. [13/6]
❕ - Line 1600, Col 3 - Metrics/MethodLength - Method has too many lines. [31/25]

spec/controllers/application_controller/report_data_spec.rb

❗ - Line 16, Col 3 - Metrics/BlockLength - Block has too many lines. [26/25]
❗ - Line 1, Col 1 - Metrics/BlockLength - Block has too many lines. [74/25]

karelhala · 2017-03-06T16:58:58Z

Closing because travis is testing wrong commit. I will reopen this as new PR.

karelhala changed the title ~~Change report data to be rendered using angular~~ [WIP] Change report data to be rendered using angular Dec 23, 2016

miq-bot added the wip label Dec 23, 2016

karelhala force-pushed the report_data branch 4 times, most recently from c33a689 to 4639a44 Compare January 3, 2017 15:29

miq-bot added the unmergeable label Jan 4, 2017

karelhala force-pushed the report_data branch from 4639a44 to 6dfe568 Compare January 5, 2017 11:22

miq-bot removed the unmergeable label Jan 5, 2017

karelhala force-pushed the report_data branch 2 times, most recently from 70e60bd to 04e6ca5 Compare January 5, 2017 14:05

miq-bot added the unmergeable label Jan 5, 2017

karelhala force-pushed the report_data branch from 04e6ca5 to ba8496b Compare January 6, 2017 13:36

miq-bot removed the unmergeable label Jan 6, 2017

miq-bot added unmergeable and removed unmergeable labels Jan 6, 2017

karelhala force-pushed the report_data branch 2 times, most recently from dd60304 to 1d1a48d Compare January 9, 2017 12:18

martinpovolny reviewed Jan 10, 2017

View reviewed changes

karelhala added 21 commits March 6, 2017 17:45

Do not render twice if explorer data are fetched from report_datA

4ac8ef8

Change show_list in get_node_info to _show_list if unused

53f4fca

Fetch view_to_url with parent if present in report_data

297f011

If no name is found in quadicon genration return blank string, if rep…

0fcdfad

…ort does not have downcase, do not return any image and show default image in report data

When displaying instances show Vm model, if images show template mode…

5bd71bb

…l in report_data

Enable tagging from nested displays

4f36a47

Fetch icon from listicon_glyphicon for each report item

86509e3

Change icon to check if it can be created via glyphicon Show items in per page picker

Add translateTotalOf to report data

b0acead

Add DB to params when assigning policies

9753df2

Enable setting ownership and policy assigment trough storing selected…

893f38b

…_ids in @edit

Enable setting ownership and policy simulation of VM's from nested view

0fd4021

Align paginagion with buttons, if some buttons are present in bottom …

7b0ffd4

…panel

Update options of all foreman nodes for getting their info

7247ad7

Send selected record IDs in report data, this way it's possible to sh…

40a3af9

…ow ownership in nested screens

When in user configuration, return view and pages, also fetch correct…

ce8ddf9

… class for icon based on view.db and row Use noSelectBox in bower

Add selected retirement items to edit object in report data

8bfa731

Send correct pictures to workers in report data, parse selected IDs f…

0412126

…rom string to integer, After clicking in configuration on GTL activete coresponding tree

Show correct VM in service explorer

b779e06

Add correct url when clicked on item

4c7bc34

Use to json on array to avoid XSS in report data

04ea706

Add option to start policy simulation with report data in angular

296c6e4

Add correct policies in nested view Add explorer when adding policy for simulation if explorer is in @edit

karelhala force-pushed the report_data branch from 79ff5d5 to 296c6e4 Compare March 6, 2017 16:52

dclarizio requested a review from himdel March 6, 2017 16:52

karelhala closed this Mar 6, 2017

This was referenced Mar 6, 2017

Report data angular #591

Closed

Report data in angular #592

Merged

This was referenced May 4, 2017

GTL - reintroduce old paging controls #1261

Closed

GTL - remove sandpaper #1262

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change report data to be rendered using angular #26

Change report data to be rendered using angular #26

karelhala commented Dec 23, 2016 •

edited

Loading

karelhala commented Dec 23, 2016

karelhala commented Dec 23, 2016

miq-bot commented Dec 23, 2016

karelhala commented Jan 4, 2017

karelhala commented Jan 6, 2017

martinpovolny Jan 10, 2017

martinpovolny Jan 10, 2017

martinpovolny Jan 10, 2017

martinpovolny Jan 10, 2017

karelhala Jan 12, 2017 •

edited by chessbyte

Loading

martinpovolny Jan 10, 2017

martinpovolny Jan 10, 2017

martinpovolny commented Jan 10, 2017

miq-bot commented Mar 6, 2017

karelhala commented Mar 6, 2017

		@@ -297,21 +298,18 @@ def get_node_info(treenodeid)
		end

		case model

		@@ -554,22 +556,22 @@ def get_node_info(treenodeid)

		case model

Change report data to be rendered using angular #26

Change report data to be rendered using angular #26

Conversation

karelhala commented Dec 23, 2016 • edited Loading

Purpose or Intent

karelhala commented Dec 23, 2016

karelhala commented Dec 23, 2016

miq-bot commented Dec 23, 2016

karelhala commented Jan 4, 2017

karelhala commented Jan 6, 2017

martinpovolny Jan 10, 2017

Choose a reason for hiding this comment

martinpovolny Jan 10, 2017

Choose a reason for hiding this comment

martinpovolny Jan 10, 2017

Choose a reason for hiding this comment

martinpovolny Jan 10, 2017

Choose a reason for hiding this comment

karelhala Jan 12, 2017 • edited by chessbyte Loading

Choose a reason for hiding this comment

martinpovolny Jan 10, 2017

Choose a reason for hiding this comment

martinpovolny Jan 10, 2017

Choose a reason for hiding this comment

martinpovolny commented Jan 10, 2017

miq-bot commented Mar 6, 2017

karelhala commented Mar 6, 2017

karelhala commented Dec 23, 2016 •

edited

Loading

karelhala Jan 12, 2017 •

edited by chessbyte

Loading