GTL: do not set parent_id directly from params[:id]. #2631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced in ManageIQ#2383 I am failing to find a usecase where the assignment from params[:id] would be needed so I am removing it. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1509171
|
Checked commit martinpovolny@06c6b66 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
karelhala
approved these changes
Nov 6, 2017
|
@mzazrivec looks good to me, can you merge it? |
simaishi
pushed a commit
that referenced
this pull request
Nov 7, 2017
GTL: do not set parent_id directly from params[:id]. (cherry picked from commit cd70754) https://bugzilla.redhat.com/show_bug.cgi?id=1510505
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in #2383
I am failing to find a usecase where the assignment from
params[:id]would be needed so I am removing it.
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1509171
Changing ownership from VM detail page.
Ping @karelhala I need to figure out why this was needed. Want to be sure it does not break something elsewhere.