Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed node id for policy link in control explorer accordion #2639

Merged
merged 1 commit into from
Nov 9, 2017

Conversation

nimrodshn
Copy link
Contributor

@nimrodshn nimrodshn commented Nov 6, 2017

Fixed node id for policy link under Control>Explorer accordion - this causes the title to compress when moving to the policy link from screens under the Explorer accordion.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1404463
cc: @cben
@simon3z

Screentshot:
Before:
screenshot from 2017-11-06 16-16-21
After:
screenshot from 2017-11-06 16-16-12

@miq-bot
Copy link
Member

miq-bot commented Nov 6, 2017

Checked commit nimrodshn@149f5bc with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@cben
Copy link
Contributor

cben commented Nov 6, 2017

Welcome back, @nimrodshn :)
LGTM.
The bug was not just causing title to "compress", it wasn't getting translated.

@mzazrivec mzazrivec self-assigned this Nov 9, 2017
@mzazrivec mzazrivec added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 9, 2017
@mzazrivec mzazrivec merged commit 18af03b into ManageIQ:master Nov 9, 2017
simaishi pushed a commit that referenced this pull request Nov 15, 2017
Fixed node id for policy link in control explorer accordion
(cherry picked from commit 18af03b)

https://bugzilla.redhat.com/show_bug.cgi?id=1511521
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit cb3b523bd077b877c38d24626bc9d13b9ab69fa6
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Nov 9 11:16:46 2017 +0100

    Merge pull request #2639 from nimrodshn/fix_id_bugs_under_policy_tree
    
    Fixed node id for policy link in control explorer accordion
    (cherry picked from commit 18af03bec598b3b28fce9a50bfc1496fc9113fbe)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1511521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants