GTL: add options needed for quadicon rendering. #2669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpovolny
force-pushed
the
quadicon_options
branch
from
6d8f968
to
4408b9f
Compare
martinpovolny
force-pushed
the
quadicon_options
branch
from
4408b9f
to
3a4cbd1
Compare
|
Checked commit martinpovolny@3a4cbd1 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Nov 15, 2017
GTL: add options needed for quadicon rendering. (cherry picked from commit 581d682) https://bugzilla.redhat.com/show_bug.cgi?id=1513590 https://bugzilla.redhat.com/show_bug.cgi?id=1513591
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To properly render quadicons a set of controller instance variables is needed :-(
This PR adds this to the /report_data interface.
This is a partial fix for:
https://bugzilla.redhat.com/show_bug.cgi?id=1501376
https://bugzilla.redhat.com/show_bug.cgi?id=1503076
There are more problems with that area.
@ZitaNemeckova is working on one issue and @karelhala is working on another.