Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "logging Output" field to Ansible Catalog Item editor. #2672

Merged

Conversation

h-kataria
Copy link
Contributor

@tinaafitz
Copy link
Member

@h-kataria Tested log_output changes and it looks good.

@h-kataria h-kataria force-pushed the add_log_output_for_catalog_item branch from 8c55aa0 to 5c6903b Compare November 8, 2017 22:53
@miq-bot
Copy link
Member

miq-bot commented Nov 8, 2017

Checked commit h-kataria@5c6903b with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 2 offenses detected

spec/controllers/catalog_controller_spec.rb

@mzazrivec mzazrivec assigned mzazrivec and unassigned dclarizio Nov 9, 2017
@mzazrivec mzazrivec added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 9, 2017
@mzazrivec mzazrivec merged commit 20f6043 into ManageIQ:master Nov 9, 2017
simaishi pushed a commit that referenced this pull request Nov 15, 2017
Added "logging Output" field to Ansible Catalog Item editor.
(cherry picked from commit 20f6043)

https://bugzilla.redhat.com/show_bug.cgi?id=1511546
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 89b47630fdb51dd13f77335a525903fcd247c9dd
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Nov 9 10:22:42 2017 +0100

    Merge pull request #2672 from h-kataria/add_log_output_for_catalog_item
    
    Added "logging Output" field to Ansible Catalog Item editor.
    (cherry picked from commit 20f6043f629aa8f01d0f6ed8e0d030bac37920f3)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1511546

@h-kataria h-kataria deleted the add_log_output_for_catalog_item branch November 17, 2017 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants