Fixed to initialize Dialog drop down correctly. #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added check in jasmine spec test to verify JS controller sets value correctly, and fixed existing checks to check against value that is being set in JS controller instead of mock value. https://bugzilla.redhat.com/show_bug.cgi?id=1500833
|
Checked commit h-kataria@e92071a with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@h-kataria Tested changes, it looks good. |
simaishi
pushed a commit
that referenced
this pull request
Nov 15, 2017
…id_in_edit Fixed to initialize Dialog drop down correctly. (cherry picked from commit 310c36a) https://bugzilla.redhat.com/show_bug.cgi?id=1511508
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check in jasmine spec test to verify JS controller sets value correctly, and fixed existing checks to check against value that is being set in JS controller instead of mock value.
https://bugzilla.redhat.com/show_bug.cgi?id=1500833
before
after:
@tinaafitz please test/verify.