-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display all clusters in Compute Rate Assignment page #2692
Merged
mzazrivec
merged 1 commit into
ManageIQ:master
from
hstastna:Chargeback_rate_assignment_duplicate_clusters
Nov 23, 2017
Merged
Display all clusters in Compute Rate Assignment page #2692
mzazrivec
merged 1 commit into
ManageIQ:master
from
hstastna:Chargeback_rate_assignment_duplicate_clusters
Nov 23, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@miq-bot add_label bug |
fixing https://bugzilla.redhat.com/show_bug.cgi?id=1456825 Fix displaying clusters in Compute Rate Assignment page when selecting 'Selected Cluster/Deployment Roles' in Assign to drop down menu even when clusters have the same name (and belong to different providers) so the name of their providers was added to their original names as prefix.
eac8915
to
9716715
Compare
Checked commit hstastna@9716715 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Nov 27, 2017
…licate_clusters Display all clusters in Compute Rate Assignment page (cherry picked from commit 1785f34) https://bugzilla.redhat.com/show_bug.cgi?id=1517918
Gaprindashvili backport details:
|
simaishi
pushed a commit
that referenced
this pull request
Nov 28, 2017
…licate_clusters Display all clusters in Compute Rate Assignment page (cherry picked from commit 1785f34) https://bugzilla.redhat.com/show_bug.cgi?id=1518392
Fine backport details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing https://bugzilla.redhat.com/show_bug.cgi?id=1456825
Fix displaying clusters in Compute Rate Assignment page when selecting
'Selected Cluster/Deployment Roles' in Assign to drop down menu even
when clusters have the same name (and belong to different providers) so
the name of their providers was added to their original names as prefix.
Before:
![cluster1](https://user-images.githubusercontent.com/13417815/32658922-818a4d9e-c61c-11e7-9094-bff76763a00a.png)
After:
![cluster2](https://user-images.githubusercontent.com/13417815/32658925-842f3cb2-c61c-11e7-9dc2-68e07cfadc90.png)