Simplify ansibleCredentialOptions angular component #2698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can pass options of the particular credential type to the component right away. That would make the whole component simpler. At the same time, this fix would resolve some obscure angular timing issues, which would lead to the credential form not being rendered correctly in certain situations. https://bugzilla.redhat.com/show_bug.cgi?id=1510855
|
Checked commit mzazrivec@bcbd679 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@himdel Review please? |
|
or @ZitaNemeckova, @AparnaKarve ? can we merge this one? |
|
@miq-bot assign @ZitaNemeckova |
|
Tested in UI. LGTM 👍 |
simaishi
pushed a commit
that referenced
this pull request
Nov 15, 2017
…ptions_component Simplify ansibleCredentialOptions angular component (cherry picked from commit c5c729f) https://bugzilla.redhat.com/show_bug.cgi?id=1513119
|
Gaprindashvili backport details: |
|
Adding |
simaishi
pushed a commit
that referenced
this pull request
Jan 22, 2018
…ptions_component Simplify ansibleCredentialOptions angular component (cherry picked from commit c5c729f) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1537015
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can pass options of the particular credential type to the component right away. That would
make the whole component simpler.
At the same time, this fix would resolve some obscure angular timing issues, which would lead
to the credential form not being rendered correctly in certain situations.
https://bugzilla.redhat.com/show_bug.cgi?id=1510855