Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Vm/Chargeback tab [ui-part] #270

Merged
merged 1 commit into from
Jan 30, 2017
Merged

Introduce Vm/Chargeback tab [ui-part] #270

merged 1 commit into from
Jan 30, 2017

Conversation

isimluk
Copy link
Member

@isimluk isimluk commented Jan 29, 2017

For the ability to quickly view chargeback of a single VM. That is useful to get a quick notion of costs associated with the given VM.

This depends on backed ManageIQ/manageiq#13687.

Button here

button

Chargeback Preview

cb

This is proof of concept. I plan to put there a chart and more information later.

@isimluk
Copy link
Member Author

isimluk commented Jan 29, 2017

@miq-bot add_label chargeback, ui, enhancement, euwe/no
@miq-bot assign @martinpovolny

@miq-bot
Copy link
Member

miq-bot commented Jan 29, 2017

@isimluk Cannot apply the following label because they are not recognized: chargeback

For the ability to quickly view chargeback of a single VM. That is
usuful to get a quick notion of costs associated with the given VM.
@miq-bot
Copy link
Member

miq-bot commented Jan 30, 2017

Checked commit https://github.com/isimluk/manageiq-ui-classic/commit/6158340185e96a6b2e7f8c58282781d22480d485 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 1 offense detected

app/controllers/mixins/chargeback_preview.rb

  • ❕ - Line 4, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for vm_chargeback is too high. [31.38/20]

@martinpovolny martinpovolny merged commit b7b59b0 into ManageIQ:master Jan 30, 2017
@martinpovolny martinpovolny added this to the Sprint 53 Ending Jan 30, 2017 milestone Jan 30, 2017
@isimluk isimluk deleted the vm-chargeback-tab branch January 30, 2017 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants