Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display flash message during duplicate class add #2706

Merged
merged 1 commit into from
Nov 14, 2017

Conversation

hstastna
Copy link

fixing https://bugzilla.redhat.com/show_bug.cgi?id=1428424

Display flash message in Automation -> Automate -> Explorer ->
Datastore
tab when creating a new Class with an existing name.
The flash message informs that the name was already been taken.

Before:
class1

After:
class2

fixing https://bugzilla.redhat.com/show_bug.cgi?id=1428424

Display flash message in Automation -> Automate -> Explorer ->
Datastore tab when creating a new Class with an existing name.
The flash message informs that the name was already been taken.
@hstastna
Copy link
Author

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Nov 13, 2017
@miq-bot
Copy link
Member

miq-bot commented Nov 13, 2017

Checked commit hstastna@83a397f with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@mzazrivec mzazrivec self-assigned this Nov 14, 2017
@mzazrivec mzazrivec added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 14, 2017
@mzazrivec mzazrivec merged commit 335987e into ManageIQ:master Nov 14, 2017
simaishi pushed a commit that referenced this pull request Nov 15, 2017
Display flash message during duplicate class add
(cherry picked from commit 335987e)

https://bugzilla.redhat.com/show_bug.cgi?id=1513601
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 01803f5bf0d0ff1858c16311425a8a84eaa58757
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Tue Nov 14 13:42:48 2017 +0100

    Merge pull request #2706 from hstastna/Flash_duplicate_class_add
    
    Display flash message during duplicate class add
    (cherry picked from commit 335987ef49a09bb3410068d1aa3eb0e25d0af26c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1513601

simaishi pushed a commit that referenced this pull request Nov 20, 2017
Display flash message during duplicate class add
(cherry picked from commit 335987e)

https://bugzilla.redhat.com/show_bug.cgi?id=1515402
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit bdcbae14ec05a6069e4f77b49fb563f97fbf9f28
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Tue Nov 14 13:42:48 2017 +0100

    Merge pull request #2706 from hstastna/Flash_duplicate_class_add
    
    Display flash message during duplicate class add
    (cherry picked from commit 335987ef49a09bb3410068d1aa3eb0e25d0af26c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1515402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants