Zones - Save NTP settings before assigning vars for edit #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chrisarcand 'bdunne' is an invalid assignee, ignoring... |
|
@miq-bot Go home, you're drunk |
|
@chrisarcand unrecognized command 'Go', ignoring... Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
bdunne
reviewed
Nov 15, 2017
| @@ -28,8 +28,10 @@ def zone_edit | |||
| javascript_flash(:spinner_off => true) | |||
| return | |||
| end | |||
| # zone = @zone.id.blank? ? Zone.new : Zone.find(@zone.id) # Get new or existing record | |||
|
|
|||
| zone_save_ntp_server_settings(@zone) | |||
There was a problem hiding this comment.
I think we need this after the @zone.save to avoid the case where the zone does not yet have an id, right?
chrisarcand
force-pushed
the
bz-1509172
branch
from
d363eb5
to
e087072
Compare
With the changes to NTP settings made in ManageIQ@97088de, calling #add_settings_for_resource calls a save and reload which sets the attributes assigned before the call to their original values, ignoring the assignments from the form. Instead, pull NTP settings outside of zone_set_record_vars, which is supposed to be just setting vars, and save the settings afterward. https://bugzilla.redhat.com/show_bug.cgi?id=1509172
chrisarcand
force-pushed
the
bz-1509172
branch
from
e087072
to
c6b835a
Compare
|
Checked commit chrisarcand@c6b835a with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Nov 21, 2017
Zones - Save NTP settings before assigning vars for edit (cherry picked from commit 018270b) https://bugzilla.redhat.com/show_bug.cgi?id=1509452
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes to NTP settings made in 97088de, calling #add_settings_for_resource calls a save and reload which sets the attributes assigned before the call to their original values, ignoring the assignments from the form.
Instead, pull NTP settings outside of zone_set_record_vars, which is supposed to be just setting vars, and save it beforehand.
https://bugzilla.redhat.com/show_bug.cgi?id=1509172