postService - skipError on 400, deduplicate #2728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go to Services > Catalogs, Catalog Items accordion create a new Catalog Item, of type Ansible Playbook do stuff to trigger a validation error on saving (duplicate name, badly configured embedded ansible) Before - you'll see the error modal pop up, and a flash message. Now - you'll only see the flash message. This also cleans up postService: * there were 2 identical brances differing in `action: 'edit'` vs `action: 'create'` * handleSuccess handled errors, separately from handleFailure but same way * $timeout was being used to compensate for not having originally injected the angular API variant (`postService` is only used by that single form - but that's a TODO for later) https://bugzilla.redhat.com/show_bug.cgi?id=1509809
himdel
changed the title
simaishi
pushed a commit
that referenced
this pull request
Nov 15, 2017
postService - skipError on 400, deduplicate (cherry picked from commit 95966af) https://bugzilla.redhat.com/show_bug.cgi?id=1513618
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go to Services > Catalogs, Catalog Items accordion
create a new Catalog Item, of type Ansible Playbook
do stuff to trigger a validation error on saving (duplicate name, badly configured embedded ansible)
Before - you'll see the error modal pop up, and a flash message.
Now - you'll only see the flash message.
This also cleans up
postService:action: 'edit'vsaction: 'create'handleSuccesshandled errors, separately fromhandleFailurebut same way$timeoutwas being used to compensate for not having originally injected the angular API variant(
postServiceis only used by that single form - but that's a TODO for later)https://bugzilla.redhat.com/show_bug.cgi?id=1509809
(
at this point, I'm only assuming the BZ is about this, butthis goes in line with #2075 and #2604)