Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the haml indentation for custom image #2734

Merged

Conversation

AparnaKarve
Copy link
Contributor

Adjust the haml indentation to adjust the issue of Custom Image being displayed in the GO instances listview.

https://bugzilla.redhat.com/show_bug.cgi?id=1513185

Before:
screen shot 2017-11-14 at 2 31 30 pm

After:
screen shot 2017-11-14 at 2 33 21 pm

This fixes the custom image being displayed in the GO list
@AparnaKarve
Copy link
Contributor Author

@miq_bot add_label bug,gaprindashvili/yes,generic objects

@miq-bot
Copy link
Member

miq-bot commented Nov 14, 2017

Checked commit AparnaKarve@625e193 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

app/views/generic_object_definition/_show_god.html.haml

  • ⚠️ - Line 14 - Prefer to_s over string interpolation.

@mzazrivec mzazrivec self-assigned this Nov 15, 2017
@mzazrivec mzazrivec added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 15, 2017
@mzazrivec mzazrivec merged commit 06e5ff7 into ManageIQ:master Nov 15, 2017
simaishi pushed a commit that referenced this pull request Nov 15, 2017
…image_issue

Adjust the haml indentation for custom image
(cherry picked from commit 06e5ff7)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 1740c3a92de8ca539784af8fb677de3e287a334c
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Wed Nov 15 11:00:53 2017 +0100

    Merge pull request #2734 from AparnaKarve/adjust_haml_indent_and_fix_image_issue
    
    Adjust the haml indentation for custom image
    (cherry picked from commit 06e5ff7fba4d0883492b1f7875d7ac88b948d5d0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants