show error message when deleting router #2737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-demicev
force-pushed
the
router-delete-error-msg
branch
from
26efebb
to
d99f9e3
Compare
mzazrivec
reviewed
Nov 20, 2017
| @@ -167,6 +167,8 @@ def delete_network_routers | |||
| router = NetworkRouter.find_by(:id => s) | |||
| if router.nil? | |||
| add_flash(_("Router no longer exists."), :error) | |||
| elsif !router.supports?(:delete) | |||
| add_flash(_("%{reason}") % {:reason => router.unsupported_reason(:delete)}, :error) | |||
There was a problem hiding this comment.
I'd say, as long as router.unsupported_reason(:delete) returns a string, you can just as well use:
add_flash(_(router.unsupported_reason(:delete)), :error)
alexander-demicev
force-pushed
the
router-delete-error-msg
branch
from
d99f9e3
to
e98db4a
Compare
alexander-demicev
force-pushed
the
router-delete-error-msg
branch
from
e98db4a
to
4f56bed
Compare
|
Checked commit alexander-demicev@4f56bed with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@mzazrivec Hi, related PR is merged. Can I ask you to review this again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Router is not deleted if delete action is not supported and shows error message
Fixes this BZ https://bugzilla.redhat.com/show_bug.cgi?id=1470754