Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add menu_click and sb_controller for additional data in report data #2740

Merged

Conversation

karelhala
Copy link
Contributor

@karelhala karelhala commented Nov 15, 2017

Fixes wrong number of items when clicking through Utilization graph #2723

When in Datasources -> Utilization graph and clicking on display VMs or Hosts wrong number of items was returned, this PR fixes such issue.

UI changes

Before

screenshot from 2017-11-15 15-16-53

After

screenshot from 2017-11-15 15-13-30

@karelhala
Copy link
Contributor Author

@miq-bot add_label bug,gaprindashvili/yes, gtls
@miq-bot assign @martinpovolny
@martinpovolny this is the best approach I could come up with, however this needs to be changes, because this feel hacky and the worst thing is that it relies on session, which is bad. But for this release it's OK, just needs to be refactored in future.

@miq-bot
Copy link
Member

miq-bot commented Nov 15, 2017

Checked commit karelhala@7bb97f7 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. ⭐

@martinpovolny
Copy link
Member

Tested manually. This works and concludes the fixes for BZs:

https://bugzilla.redhat.com/show_bug.cgi?id=1512842
https://bugzilla.redhat.com/show_bug.cgi?id=1511498

For adding a test for this I need: #2727

So I will be adding a spec in another PR.

@martinpovolny martinpovolny merged commit a414345 into ManageIQ:master Nov 16, 2017
@martinpovolny martinpovolny added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 16, 2017
simaishi pushed a commit that referenced this pull request Nov 17, 2017
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit cfa4f890efbe627ebf30cf25bb4395cdec5113d4
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Thu Nov 16 12:13:27 2017 +0100

    Merge pull request #2740 from karelhala/menuClickSbControllerAdditionalData
    
    Add menu_click and sb_controller for additional data in report data
    (cherry picked from commit a41434567657f5d3df41e701a5900fd1593bd9a3)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1514518
    https://bugzilla.redhat.com/show_bug.cgi?id=1514519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants