Do not show record's info when status of record is not completed #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karelhala
force-pushed
the
savedReport
branch
from
ff88548
to
3dfd47f
Compare
|
@miq-bot assign @martinpovolny |
skateman
reviewed
Nov 22, 2017
| :javascript | ||
| miq_tabs_init('#rep_tabs', '/report/rep_change_tab'); | ||
| - if @report.nil? | ||
| = render :partial => 'layouts/info_msg', :locals => {:message => _("No Reports available.")} |
karelhala
force-pushed
the
savedReport
branch
from
3dfd47f
to
33650be
Compare
|
@karelhala your fix causes a regression at the queued node's parent. Before: After: |
karelhala
force-pushed
the
savedReport
branch
from
33650be
to
5848705
Compare
|
Checked commit karelhala@5848705 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Nov 27, 2017
Do not show record's info when status of record is not completed (cherry picked from commit 00c69cc) https://bugzilla.redhat.com/show_bug.cgi?id=1517942
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes error when navigating to not yet finished report
When queuing new report in CI -> reports, and the report is not yet finished it will throw nasty error. This PR fixes such issue and won't allow users to do changes to such report unless it's finished.
UI changes
Before
After
BZ
https://bugzilla.redhat.com/show_bug.cgi?id=1508152