Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render Generic Object Definition center toolbar for show properly #2808

Conversation

AparnaKarve
Copy link
Contributor

Fixed the toolbar rendering while displaying a Generic Object Definition record from the screen below where @display = 'main' -

screen shot 2017-11-22 at 12 10 57 pm

https://bugzilla.redhat.com/show_bug.cgi?id=1515942

@AparnaKarve
Copy link
Contributor Author

@miq_bot add_label bug,generic objects,gaprindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Nov 22, 2017

Some comments on commits AparnaKarve/manageiq-ui-classic@f7d0845~...b1d8a62

spec/controllers/generic_object_definition_controller_spec.rb

  • ⚠️ - 24 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

@miq-bot
Copy link
Member

miq-bot commented Nov 22, 2017

Checked commits AparnaKarve/manageiq-ui-classic@f7d0845~...b1d8a62 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 2 offenses detected

app/helpers/application_helper/toolbar/generic_object_definition_center.rb

  • ❗ - Line 37, Col 3 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
  • ❗ - Line 3, Col 5 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

@h-kataria
Copy link
Contributor

changes look good

@h-kataria h-kataria added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 22, 2017
@h-kataria h-kataria merged commit 25585bf into ManageIQ:master Nov 22, 2017
simaishi pushed a commit that referenced this pull request Nov 27, 2017
…en_display_is_main

Render Generic Object Definition center toolbar for `show` properly
(cherry picked from commit 25585bf)

https://bugzilla.redhat.com/show_bug.cgi?id=1517909
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 6591fde67ab260e6895f282db8bf7225bf8ab169
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Wed Nov 22 16:14:44 2017 -0500

    Merge pull request #2808 from AparnaKarve/bz1515942_render_toolbar_when_display_is_main
    
    Render Generic Object Definition center toolbar for `show` properly
    (cherry picked from commit 25585bfa44545efd5951afa40e0f9bd53b5af6f4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1517909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants