Fix Service request filtering #2830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpovolny
force-pushed
the
miq_request_fix
branch
from
61942af
to
e7c2c35
Compare
|
Some comments on commits martinpovolny/manageiq-ui-classic@d159956~...54c3eec spec/controllers/miq_request_controller_spec.rb
|
|
Checked commits martinpovolny/manageiq-ui-classic@d159956~...54c3eec with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
martinpovolny
changed the title
|
I'm OK with the changes. @karelhala ? |
|
@karelhala loves it we discussed f2f ;-) |
simaishi
pushed a commit
that referenced
this pull request
Nov 28, 2017
Fix Service request filtering (cherry picked from commit 7089223) https://bugzilla.redhat.com/show_bug.cgi?id=1518302
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproducer
ApplyBZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1512719
Closes: #2742
@mzazrivec : PTAL
TODO:
Looking as some strange stuff in the case statement,will be done in a separate PR.looking at what code to removeremoved just a bitExplanation:
The filters are composed from SQL fragments. So no scopes for now :-(.
It's handled (statefully) in
/report_datavia the "exceptions". This one is for "MiqRequest" and callspage_params.So we can keep the code that updates the session when form fields are changed. (That needs a rework no soner then when it's redone to client side.)
And all that is really needed is the reload of the GTL grid -- that will reload
/report_dataand apply the changed filter (remember, it's in the session). So doing just that.