Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flash message when OrchestrationStack delete returns an exception #2836

Merged
merged 2 commits into from
Nov 28, 2017

Conversation

ZitaNemeckova
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova commented Nov 27, 2017

Steps to reproduce:

Compute -> Cloud -> Stacks
Check one Orchestration Stack
Configuration -> Remove Orchestration Stack from Inventory
Check again Orchestration Stack that was deleted
Configuration -> Remove Orchestration Stack from Inventory

Before:
screen shot 2017-11-27 at 2 16 06 pm
After:
screen shot 2017-11-27 at 5 10 32 pm

@miq-bot add_label bug, gaprindashvili/yes, blocker

@h-kataria please have a look, thanks :) Maybe you can think about nicer error message.

https://bugzilla.redhat.com/show_bug.cgi?id=1515310

@miq-bot
Copy link
Member

miq-bot commented Nov 28, 2017

Checked commits ZitaNemeckova/manageiq-ui-classic@cead77d~...27a7096 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@mzazrivec mzazrivec self-assigned this Nov 28, 2017
@mzazrivec mzazrivec added this to the Sprint 75 Ending Dec 11, 2017 milestone Nov 28, 2017
@mzazrivec mzazrivec merged commit aa8481f into ManageIQ:master Nov 28, 2017
@ZitaNemeckova ZitaNemeckova deleted the fix_repetetive_delete branch November 28, 2017 10:02
simaishi pushed a commit that referenced this pull request Nov 28, 2017
Add flash message when OrchestrationStack delete returns an exception
(cherry picked from commit aa8481f)

https://bugzilla.redhat.com/show_bug.cgi?id=1515310
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 43276a770ede250bd97574833449e9dc941bbcfc
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Tue Nov 28 10:59:26 2017 +0100

    Merge pull request #2836 from ZitaNemeckova/fix_repetetive_delete
    
    Add flash message when OrchestrationStack delete returns an exception
    (cherry picked from commit aa8481f05349834373bb4780518a10c3e2bf52c1)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1515310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants