GenericFeatureButton - don't catch NoMethodError #2848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, if a `@record` has a `supports_foo?` method, but calling that method fails with a `NoMethodError`, `GenericFeatureButton#visible?` will try to fall back to `AvailabilityMixin` and fail on missing `is_available?`. We should only fall back to `is_available?` if the actual `supports_foo?` is missing. Thus, using `respon_to?` to decide which to call, and not catching any exceptions.
|
The method should actually just say |
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/0704f609937b826e854084826e39bfad9caddd45 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if a
@recordhas asupports_foo?method, but calling that method fails with aNoMethodError,GenericFeatureButton#visible?will try to fall back toAvailabilityMixinand fail on missingis_available?.We should only fall back to
is_available?if the actualsupports_foo?is missing.Thus, using
respond_to?to decide which to call, and not catching any exceptions.Cc @borod108
(
gaprindashvili/nobecause this does have a subtle difference in behaviour and I'm not sure this won't cause any regressions..)