Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refer ::Settings value before rendering SmartState docker credentials #2853

Merged
merged 1 commit into from
Nov 28, 2017
Merged

Refer ::Settings value before rendering SmartState docker credentials #2853

merged 1 commit into from
Nov 28, 2017

Conversation

AparnaKarve
Copy link
Contributor

@AparnaKarve AparnaKarve commented Nov 28, 2017 •
edited
Loading

@miq-bot
Copy link
Member

miq-bot commented Nov 28, 2017

Checked commit AparnaKarve@b1978d1 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@AparnaKarve
Copy link
Contributor Author

@miq-bot add_label bug,gaprindashvili/yes,compute/cloud

@h-kataria h-kataria self-assigned this Nov 28, 2017
@h-kataria
Copy link
Contributor

looks good.

@h-kataria h-kataria added this to the Sprint 75 Ending Dec 11, 2017 milestone Nov 28, 2017
@h-kataria h-kataria merged commit 86af68d into ManageIQ:master Nov 28, 2017
simaishi pushed a commit that referenced this pull request Nov 29, 2017
@h-kataria @simaishi
Merge pull request #2853 from AparnaKarve/bz1517061_fix_save_for_aws
1a72149 
Refer `::Settings` value before rendering SmartState docker credentials
(cherry picked from commit 86af68d)

https://bugzilla.redhat.com/show_bug.cgi?id=1518742
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 1a72149057ec3afa9e757b1c28978db2bde906b2
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Tue Nov 28 17:30:48 2017 -0500

    Merge pull request #2853 from AparnaKarve/bz1517061_fix_save_for_aws
    
    Refer `::Settings` value before rendering SmartState docker credentials
    (cherry picked from commit 86af68ddc5f1d426c4b670162a53ff3c818054fc)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1518742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@h-kataria h-kataria

Labels
bug compute/cloud gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AparnaKarve @miq-bot @h-kataria @simaishi