Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bz 1455270: Fix Storage Manager label for volume lists #2866

Merged
merged 1 commit into from
Nov 30, 2017
Merged

bz 1455270: Fix Storage Manager label for volume lists #2866

merged 1 commit into from
Nov 30, 2017

Conversation

sseago
Copy link
Contributor

@sseago sseago commented Nov 29, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1455270

Cloud volume list incorrectly labeled the Storage Manager column as Cloud Provider.
This commit also fixes the same problem for Cloud Volume backups and snapshots.

@sseago
bz 1455270: Fix Storage Manager label for volume lists
3c65b0c 
https://bugzilla.redhat.com/show_bug.cgi?id=1455270

Cloud volume list incorrectly labeled the Storage Manager column as Cloud Provider.
This commit also fixes the same problem for Cloud Volume backups and snapshots.
@miq-bot
Copy link
Member

miq-bot commented Nov 29, 2017

Checked commit sseago@3c65b0c with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@chessbyte
Copy link
Member

@sseago if this needs to be backported to Gaprindashvili, then please add label gaprindashvili/yes

@mansam
Copy link
Contributor

mansam commented Nov 29, 2017

@miq-bot add_label gaprindashvili/yes
@miq-bot add_label fine/yes

@mzazrivec mzazrivec self-assigned this Nov 30, 2017
@mzazrivec mzazrivec added this to the Sprint 75 Ending Dec 11, 2017 milestone Nov 30, 2017
@mzazrivec mzazrivec merged commit 03b63a4 into ManageIQ:master Nov 30, 2017
simaishi pushed a commit that referenced this pull request Nov 30, 2017
@mzazrivec @simaishi
Merge pull request #2866 from sseago/cloud_volume_provider_labels
2716d74 
bz 1455270: Fix Storage Manager label for volume lists
(cherry picked from commit 03b63a4)

https://bugzilla.redhat.com/show_bug.cgi?id=1519490
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 2716d74aa4bc74ef0f9358742d59fcdb9381ba37
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Nov 30 14:28:02 2017 +0100

    Merge pull request #2866 from sseago/cloud_volume_provider_labels
    
    bz 1455270: Fix Storage Manager label for volume lists
    (cherry picked from commit 03b63a4d3c9befd2091d3f725c71a06bf1d5f9d4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1519490

@simaishi
Copy link
Contributor

simaishi commented Dec 1, 2017

Fine backport (to manageiq repo) details:

$ git log -1
commit cb6d8d0870a9eed2bf0a290ef8270a593a2141d0
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Nov 30 14:28:02 2017 +0100

    Merge pull request #2866 from sseago/cloud_volume_provider_labels
    
    bz 1455270: Fix Storage Manager label for volume lists
    (cherry picked from commit 03b63a4d3c9befd2091d3f725c71a06bf1d5f9d4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1519915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug fine/backported gaprindashvili/backported storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sseago @miq-bot @chessbyte @mansam @simaishi @mzazrivec