ToolbarController#setClickHandler - don't handle click for disabled toolbar items #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oolbar items clicking on a disabled toolbar item doesn't really do anything in `miqToolbarOnClick`, but the `itemClicked` rx message still got sent, causing the paging toolbar to disappear (by calling `ReportDataController#setExtraClasses`). Changing to only send the event when a visible non-disabled button is clicked. https://bugzilla.redhat.com/show_bug.cgi?id=1518929
|
(the diff looks ugly because there was an off-by-one formatting - the code was indented at an odd (ie. not even) level of indentation - use whitespace-insensitive diff) |
karelhala
approved these changes
Nov 30, 2017
simaishi
pushed a commit
that referenced
this pull request
Dec 1, 2017
ToolbarController#setClickHandler - don't handle click for disabled toolbar items (cherry picked from commit d27872b) https://bugzilla.redhat.com/show_bug.cgi?id=1519841
|
Gaprindashvili backport details: |
|
Seems like @nimrodshn found a proper fix in #3062 :). But maybe we should still keep this as well, since doing anything when clicking disabled buttons is probably still wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clicking on a disabled toolbar item doesn't really do anything in
miqToolbarOnClick, but theitemClickedrx message still got sent, causing the paging toolbar to disappear (by callingReportDataController#setExtraClasses).Changing to only send the event when a visible non-disabled button is clicked.
https://bugzilla.redhat.com/show_bug.cgi?id=1518929
Cc @karelhala