Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for nil Clusters/Datastores on C/U tab #2886

Merged
merged 1 commit into from
Dec 1, 2017
Merged

Check for nil Clusters/Datastores on C/U tab #2886

merged 1 commit into from
Dec 1, 2017

Conversation

bmclaughlin
Copy link
Contributor

Show a note if there is no data to populate the Clusters and/or Datastore trees on the C/U tab under Configuration.

@miq-bot add_label bug, settings, blocker

https://bugzilla.redhat.com/show_bug.cgi?id=1518087

@miq-bot
Copy link
Member

miq-bot commented Nov 30, 2017

Checked commit bmclaughlin@cfe7ee9 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 2 offenses detected

app/views/ops/_settings_cu_collection_tab.html.haml

  • ⚠️ - Line 23 - Line is too long. [198/160]
  • ⚠️ - Line 38 - Line is too long. [271/160]

@h-kataria h-kataria self-assigned this Nov 30, 2017
@h-kataria
Copy link
Contributor

changes looks good, @bmclaughlin can you provide a screenshot of screen with a Note.

@bmclaughlin
Copy link
Contributor Author

1518087-after

@h-kataria h-kataria added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 1, 2017
@h-kataria h-kataria merged commit b594fe0 into ManageIQ:master Dec 1, 2017
@bmclaughlin bmclaughlin deleted the check-for-nil-clusters-and-datastores branch December 1, 2017 14:18
@simaishi
Copy link
Contributor

simaishi commented Dec 1, 2017

Adding gaprindashvili/yes as per BZ. Can this also be fine/yes?

simaishi pushed a commit that referenced this pull request Dec 1, 2017
@h-kataria @simaishi
Merge pull request #2886 from bmclaughlin/check-for-nil-clusters-and-…
324d627 
…datastores

Check for nil Clusters/Datastores on C/U tab
(cherry picked from commit b594fe0)

https://bugzilla.redhat.com/show_bug.cgi?id=1519933
@simaishi
Copy link
Contributor

simaishi commented Dec 1, 2017

Gaprindashvili backport details:

$ git log -1
commit 324d627b1bde1e10c90a7cf49034738643b92f30
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Fri Dec 1 08:59:43 2017 -0500

    Merge pull request #2886 from bmclaughlin/check-for-nil-clusters-and-datastores
    
    Check for nil Clusters/Datastores on C/U tab
    (cherry picked from commit b594fe0c0c832df4424f7b6204ca5881dfe61e26)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1519933

@bmclaughlin
Copy link
Contributor Author

@miq-bot add_label fine/yes

simaishi pushed a commit that referenced this pull request Dec 7, 2017
@h-kataria @simaishi
Merge pull request #2886 from bmclaughlin/check-for-nil-clusters-and-…
0f7ac36 
…datastores

Check for nil Clusters/Datastores on C/U tab
(cherry picked from commit b594fe0)

https://bugzilla.redhat.com/show_bug.cgi?id=1523408
@simaishi
Copy link
Contributor

simaishi commented Dec 7, 2017

Fine backport details:

$ git log -1
commit 0f7ac36a4431ab7822a54637a4a0135d71e70088
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Fri Dec 1 08:59:43 2017 -0500

    Merge pull request #2886 from bmclaughlin/check-for-nil-clusters-and-datastores
    
    Check for nil Clusters/Datastores on C/U tab
    (cherry picked from commit b594fe0c0c832df4424f7b6204ca5881dfe61e26)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1523408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@h-kataria h-kataria

Labels
blocker bug fine/backported gaprindashvili/backported settings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bmclaughlin @miq-bot @h-kataria @simaishi