Fix loop conditional on provisioning workflow volume form #2890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzazrivec
reviewed
Dec 1, 2017
| @@ -17,6 +17,7 @@ | |||
|
|
|||
| .form-horizontal#add-volumes-form | |||
| - while (draw_fields) | |||
| = options | |||
There was a problem hiding this comment.
I'm trying to understand why is the above line here? Why are we rendering the options hash here?
There was a problem hiding this comment.
Sorry, that's a debug line that got left in. Thanks for noticing it.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1506466 The problem described in the BZ was occuring because the loop that builds the volume provisioning form was checking the wrong hash keys for its condition and terminating early.
mansam
force-pushed
the
fix-provisioning-workflow-volume-form
branch
from
88b3443
to
f731e0d
Compare
|
Checked commit mansam@f731e0d with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@mansam Can this be |
simaishi
pushed a commit
that referenced
this pull request
Dec 4, 2017
…-form Fix loop conditional on provisioning workflow volume form (cherry picked from commit 45d70e8) https://bugzilla.redhat.com/show_bug.cgi?id=1520540
|
Gaprindashvili backport details: |
|
@simaishi Yes I believe this can be backported to Euwe. |
|
@miq-bot add_label euwe/yes |
|
Euwe backport details: |
simaishi
pushed a commit
that referenced
this pull request
Dec 7, 2017
…-form Fix loop conditional on provisioning workflow volume form (cherry picked from commit 45d70e8) https://bugzilla.redhat.com/show_bug.cgi?id=1520541
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1506466
The problem described in the BZ was occuring because the
loop that builds the volume provisioning form was checking
the wrong hash keys for its condition and terminating
early.