-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI changes to show options as disabled if those are not supported. #2908
UI changes to show options as disabled if those are not supported. #2908
Conversation
This PR uses changes from backend in ManageIQ/manageiq#16559 to determine whether options in the drop down should be available or disabled based upon results returned in hash by backend method. https://bugzilla.redhat.com/show_bug.cgi?id=1515371
@h-kataria Tested looks good. |
Checked commit h-kataria@449896b with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 app/views/catalog/_st_form.html.haml |
Marking as |
@simaishi thanks Satoe . . . I somehow missed the pending label, but you can just backport once the other PR gets merged. |
This is currently breaking creation of new catalog items :(. Is the backend PR coming soon? :) |
@simaishi @himdel @dclarizio Core PR and all provider PRs have been merged and marked |
…sabled_catalog_item_types_in_drop_down UI changes to show options as disabled if those are not supported. (cherry picked from commit 19ecd2e) https://bugzilla.redhat.com/show_bug.cgi?id=1520613
Gaprindashvili backport details:
|
This PR uses changes from backend in ManageIQ/manageiq#16559 to determine whether options in the drop down should be available or disabled based upon results returned in hash by backend method.
https://bugzilla.redhat.com/show_bug.cgi?id=1515371
before all options were always available:
after:
@mkanoor please test/review.
@dclarizio please review, this PR depends upon core PR ManageIQ/manageiq#16559