MiqRequest: fix listing of affected items. #2910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpovolny
changed the title
Passing of :selected_ids throught get_view(..) is not implemented. We shall implement that after Gaprindashvili. For now pass record ids throught an instance variable.
martinpovolny
force-pushed
the
miq_request_details_grid_fix
branch
2 times, most recently
from
2b47a60
to
5ad58b6
Compare
martinpovolny
force-pushed
the
miq_request_details_grid_fix
branch
from
5ad58b6
to
237c543
Compare
|
Ping @tumido : you broke it ;-) Review, please? |
martinpovolny
changed the title
|
Some comments on commits martinpovolny/manageiq-ui-classic@9568587~...237c543 spec/controllers/miq_request_controller_spec.rb
|
|
Checked commits martinpovolny/manageiq-ui-classic@9568587~...237c543 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Dec 4, 2017
MiqRequest: fix listing of affected items. (cherry picked from commit 8a01085) https://bugzilla.redhat.com/show_bug.cgi?id=1520660
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing of :selected_ids throught get_view(..) is not implemented.
We shall implement that after Gaprindashvili.
For now pass record ids throught an instance variable.
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1513303
TODO:
write a speccreate TODO item for passing the selected_records throughget_view