Provider forms: pass flash messages throught the session rather than url #2924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpovolny
force-pushed
the
flash_messages_session
branch
from
94250db
to
d5d7576
Compare
|
ping @himdel |
|
Checked commit martinpovolny@d5d7576 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
LGTM, merged :) btw |
|
@himdel: nice! I don't know why I was not able to grep it. It's trivial and I remember I tried. Probably a blackout on my side. Anyway it's pretty simple task to replace the ones you find with the grep. Maybe we can asssign it to someone. |
simaishi
pushed a commit
that referenced
this pull request
Dec 4, 2017
Provider forms: pass flash messages throught the session rather than url (cherry picked from commit a3831c9) https://bugzilla.redhat.com/show_bug.cgi?id=1520669
|
Gaprindashvili backport details: |
|
@martinpovolny Good idea, not sure if it can wait for the next semester for the students.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provider forms: pass flash messages throught the session rather than url
https://bugzilla.redhat.com/show_bug.cgi?id=1475303