Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Grid View and Tile View for Configuration Profiles #2971

Merged

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Dec 6, 2017

Fix the Grid View and Tile View for Configuration Profiles

Depends on #2984

Links

Remaining fix for #2927

After:

screenshot from 2017-12-06 15-58-24
screenshot from 2017-12-06 15-58-27

@miq-bot miq-bot added the wip label Dec 6, 2017
@lgalis lgalis force-pushed the fix_quadicons_for_configuration_profiles branch from cdf1de4 to 795d783 Compare December 6, 2017 21:49
@lgalis lgalis force-pushed the fix_quadicons_for_configuration_profiles branch from 795d783 to 2acacd2 Compare December 6, 2017 22:19
@miq-bot
Copy link
Member

miq-bot commented Dec 6, 2017

Checked commits lgalis/manageiq-ui-classic@05d2637~...2acacd2 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 0 offenses detected
Everything looks fine. 👍

@lgalis lgalis changed the title [WIP] Fix the Grid View and Tile View for Configuration Profiles Fix the Grid View and Tile View for Configuration Profiles Dec 6, 2017
@miq-bot miq-bot removed the wip label Dec 6, 2017
@lgalis
Copy link
Contributor Author

lgalis commented Dec 7, 2017

@miq-bot add_label bug, gaprindashvili/yes
@martinpovolny - please review

@mzazrivec mzazrivec self-assigned this Dec 22, 2017
@mzazrivec mzazrivec added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 22, 2017
@mzazrivec mzazrivec merged commit 6dc6cf5 into ManageIQ:master Dec 22, 2017
@simaishi
Copy link
Contributor

simaishi commented Jan 3, 2018

Gaprindashvili backport details:

$ git log -1
commit f3ae2b6aa2a996a39fa2ee4b6fc63311e836fe3b
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Fri Dec 22 11:46:42 2017 +0100

    Merge pull request #2971 from lgalis/fix_quadicons_for_configuration_profiles
    
    Fix the Grid View and Tile View for Configuration Profiles
    (cherry picked from commit 6dc6cf542983fa16ef7da5bf5ae5b89135940548)

simaishi pushed a commit that referenced this pull request Jan 3, 2018
…profiles

Fix the Grid View and Tile View for Configuration Profiles
(cherry picked from commit 6dc6cf5)
@lgalis lgalis deleted the fix_quadicons_for_configuration_profiles branch January 3, 2018 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants