Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong icon for action in Policy Profiles #2979

Merged
merged 1 commit into from
Dec 7, 2017

Conversation

tumido
Copy link
Member

@tumido tumido commented Dec 7, 2017

The action success or failure icon is not rendered properly for Policy Profiles tree while it works fine for Policies tree. Let's provide the information about success and failure to Policy Profiles tree nodes as well.

Code is copy-pasted from app/presenters/tree_builder_policy.rb.

Policy Profiles tree:
image

Policies tree:
image

@tumido
Copy link
Member Author

tumido commented Dec 7, 2017

@miq-bot add_label bug, trees, control
cc @himdel

@himdel
Copy link
Contributor

himdel commented Dec 7, 2017

LGTM, merging when green :)

(well, LGTM because we already do that, abusing instance_variable_set seems much worse than Hash nodes ever were, but.. yeah, that's a separate issue :))

@himdel
Copy link
Contributor

himdel commented Dec 7, 2017

Cc @skateman ^

clearly, we'll need to reintroduce Hash nodes, or something similar, this is just wrong.

@miq-bot
Copy link
Member

miq-bot commented Dec 7, 2017

Checked commit tumido@6fda2ed with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@himdel
Copy link
Contributor

himdel commented Dec 7, 2017

Added gaprindashvili/yes - wrong icons in the Policy profile tree sounds like something we want to fix there as well

@himdel himdel merged commit 4835489 into ManageIQ:master Dec 7, 2017
@himdel himdel added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 7, 2017
simaishi pushed a commit that referenced this pull request Dec 11, 2017
Fix wrong icon for action in Policy Profiles
(cherry picked from commit 4835489)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 4626a0032a7e42ed302f84515041fd46215f0420
Author: Martin Hradil <himdel@seznam.cz>
Date:   Thu Dec 7 17:21:49 2017 +0000

    Merge pull request #2979 from tumido/fix_action_icon_policy_profile
    
    Fix wrong icon for action in Policy Profiles
    (cherry picked from commit 4835489aa44f7b5fbc313c64beb7dce0c3e2a5c5)

@tumido tumido deleted the fix_action_icon_policy_profile branch June 26, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants